[Webkit-unassigned] [Bug 94925] [EFL][UT]Refactoring an implementation of testing framework for wk1.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 07:34:40 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=94925





--- Comment #22 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-09-14 07:35:07 PST ---
(From update of attachment 163888)
View in context: https://bugs.webkit.org/attachment.cgi?id=163888&action=review

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:49
> +    m_ewkTestView = new EWKTestView();

You could use an OwnPtr here so you do not need to delete this pointer manually later.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h:46
>      OwnPtr<Evas_Object> m_webView;

Evas_Objects should be wrapped inside RefPtrs now.

> Source/WebKit/efl/tests/test_runner.cpp:18
>  */
> +#include "config.h"

Very minor nit: I would add an empty line before this #include.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list