[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #26 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2012-09-14 02:18:30 PST ---
(From update of attachment 163880)
View in context: https://bugs.webkit.org/attachment.cgi?id=163880&action=review

> Source/WebCore/ChangeLog:13
> +        * inspector/front-end/inspectorPageIndex.html: Added.

I don't think it belongs in WebCore, the inspector server is contained in WebKit2, so the resource should go there as well.
Source/WebKit2/UIProcess/InspectorServer/front-end would feel like a better place to me, but that means that ports might have to include it in a different resource bundle.

> Source/WebKit2/config.h:122
>  #if PLATFORM(QT)
>  #define ENABLE_INSPECTOR_SERVER 1
> +#elif PLATFORM(GTK)
> +#define ENABLE_INSPECTOR_SERVER 1

#if PLATFORM(QT) || PLATFORM(GTK)

> Source/WebKit2/UIProcess/InspectorServer/WebSocketServerConnection.cpp:130
> +    // To prevent double deletion in WebSocketServer::didCloseWebSocketServerConnection()
> +    if (!m_socket)
> +        return;

Can you elaborate on this? If in any case didCloseWebSocketServerConnection isn't run, this would prevent the server from accepting a new connection if the previous connection wasn't cleaned-up properly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.