[Webkit-unassigned] [Bug 63257] When blocking localStorage, Firefox throws a security exception on access, and maybe so should we

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63257





--- Comment #13 from Michael Nordman <michaeln at google.com>  2012-09-13 13:04:32 PST ---
(From update of attachment 163879)
View in context: https://bugs.webkit.org/attachment.cgi?id=163879&action=review

> Source/WebCore/storage/StorageAreaImpl.cpp:107
> +bool StorageAreaImpl::canAccessStorage(Frame* frame) const

Not sure about this method body? If i'm reading it right, it looks like it changes existing behavior about when storage is accessible. Are those changes intentional?

> Source/WebCore/storage/StorageAreaImpl.cpp:111
> +    if (frame->page()->settings()->privateBrowsingEnabled())

It looks like local and session storage are no longer accessible when 'private browsing' under any circumstances.

> Source/WebCore/storage/StorageAreaImpl.cpp:113
>      if (m_storageType != LocalStorage)

And SessionStorage is no longer accessible ever.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.