[Webkit-unassigned] [Bug 96655] [BLACKBERRY] Mouse events are lost.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96655





--- Comment #2 from Antonio Gomes <tonikitoo at webkit.org>  2012-09-13 08:36:38 PST ---
(From update of attachment 163883)
View in context: https://bugs.webkit.org/attachment.cgi?id=163883&action=review

> Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:182
> +    return viewportSize.width() < contentsSize.width() && viewportSize.height() < contentsSize.height();

do we want || here? so it can be scrollable in one direction only...

> Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:280
> +                if (isMainFrameScrollable(m_webPage->viewportSize(), m_webPage->contentsSize()))

Given the function name I would rather pass the m_webPage object, and check all inside.

Also, maybe we want actualVisibleViewportSize?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.