[Webkit-unassigned] [Bug 80794] :first-line pseudo selector ignoring words created from :before

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80794





--- Comment #10 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-09-12 23:41:27 PST ---
(In reply to comment #8)
> (From update of attachment 151665 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151665&action=review
> 
Thank-you for the review Elliott.

> This seems okay, but the amount of duplication between uncachedFirstLineStyle and firstLineStyleSlowCase seems bad. Can you express one in terms of the other, or add a helper?
> 
Have added a static helper function containing the duplicate code. Have also introduced an enum for differentiating between the cached and uncached style handling and to avoid passing a boolean as an input param.

> > Source/WebCore/rendering/RenderObject.cpp:2514
> > +        // For handling content generated from :before/:after pseudo-element.
> 
> Not sure these comments are needed. You have the isBeforeOrAfterContent which seems clear.
Removed the comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.