[Webkit-unassigned] [Bug 92905] BUG in QTWebkit 4.8 > Flash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 12 17:10:26 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=92905


Patrick Li <patrick at raptr.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick at raptr.com




--- Comment #6 from Patrick Li <patrick at raptr.com>  2012-09-12 17:10:52 PST ---
It's being painted to the wrong Rect.  The following patch fixes it:


Index: win/PluginViewWin.cpp
===================================================================
--- Source/WebCore/plugins/win/PluginViewWin.cpp       (revision 63895)
+++ Source/WebCore/plugins/win/PluginViewWin.cpp       (working copy)
@@ -618,7 +618,8 @@

     ASSERT(parent()->isFrameView());
     IntRect rectInWindow = static_cast<FrameView*>(parent())->contentsToWindow(
frameRect());
-    LocalWindowsContext windowsContext(context, rectInWindow, m_isTransparent);

+    HDC hdc = context->getWindowsContext(rectInWindow, m_isTransparent);
+

     // On Safari/Windows without transparency layers the GraphicsContext return
s the HDC
     // of the window and the plugin expects that the passed in DC has window co
ordinates.
@@ -627,14 +628,15 @@
 #if !PLATFORM(QT) && !OS(WINCE)
     if (!context->inTransparencyLayer()) {
         XFORM transform;
-        GetWorldTransform(windowsContext.hdc(), &transform);
+        GetWorldTransform(hdc, &transform);
         transform.eDx = 0;
         transform.eDy = 0;
-        SetWorldTransform(windowsContext.hdc(), &transform);
+        SetWorldTransform(hdc, &transform);
     }
 #endif

-    paintIntoTransformedContext(windowsContext.hdc());
+    paintIntoTransformedContext(hdc);
+    context->releaseWindowsContext(hdc, frameRect(), m_isTransparent);
 }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list