[Webkit-unassigned] [Bug 96382] Android's mock scrollbars shows up as a difference in layout test results

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96382





--- Comment #16 from Peter Beverloo <peter at chromium.org>  2012-09-12 12:21:09 PST ---
We'll (In reply to comment #10)
> (In reply to comment #7)
> > My concern is that this would make it impossible to determine whether the content exceeds the result's viewport or not.
> 
> The render tree output would at least tell you this.

Yes, but is there a reason not to?

What do you think about the following steps forward?

    1) We'll force compositor mode and threaded compositing for DumpRenderTree on Android, matching the product itself.
    2) We'll make the mock scrollbars light grey (so the scroller is visible and it's visually distinguishable from the test's content), if possible, keep the reserved space, and enable the overlay scrollbars again.
    3) We'll diagnose further failures, to make sure there isn't any low hanging fruit that may cause major re-baselines after we're done.
    4) We'll start a plan to get the tests re-based while verifying every result visually. There are various WebKit committers in London and with some tools we should be able to do this quickly and accurately.


Note for (2): Some tests may be depending on the predictable inner layout width, so I don't think we should change that, but this is a triviality.

The eventual goal is to match the product as closely as possible. Integration with garden-o-matic is planned and shouldn't be too long away, but we do need a good baseline in the first place in order for that to work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.