[Webkit-unassigned] [Bug 90968] [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90968





--- Comment #9 from János Badics <jbadics at inf.u-szeged.hu>  2012-09-12 08:59:05 PST ---
> This'll always pass the --timeout every case, is this intended? Or there will be more work on top of this?

We can test if it makes some tests fail. I suppose it shouldn't, but thank you for drawing my attention. I will check it tomorrow. It wasn't really intended, it was just a starting point.

> What does the 'k' mean? Also there is an extra () around the atoi. Hmmm... maybe we should check if there is a next token at all, like in the -p case.

Sorry, I corrected it. At first I checked for another token, but now it is given every time by NRWT, so I skipped it. Do you think it would be a better idea to check for another token, considering better future use? 

> Accessing members marked private (_options) isn't really a good idea. Maybe there is a getter for it?

I have corrected it. Now it uses get_option.

> Why is this required? In the readTimeout you'll parse the input again whit the parseInputLine method, like at the start of this method. Processing the 'command' could be performed here or not? (maybe I'm missing something?)

It has also been corrected. parseInputLine is called only once now.
I also made some style corrections.

What is your opinion about the current state? Thank you for any help in advance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.