[Webkit-unassigned] [Bug 96508] [chromium] WebViewImpl::selectionBounds should return start/end on Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96508





--- Comment #5 from Iain Merrick <husky at chromium.org>  2012-09-12 08:59:02 PST ---
(From update of attachment 163621)
View in context: https://bugs.webkit.org/attachment.cgi?id=163621&action=review

>> Source/WebKit/chromium/src/WebViewImpl.cpp:2266
>> +// FIXME: This shouldn't be OS-specific. http://webkit.org/b/96508
> 
> This is very confusing. Why are arguments called start and end, and yet they expect it to be base and extent? Furthermore, they aren't base and extent. They're anchor and focus.
> The terminology here is all messed up. Please fix them.
> 
> Also, we should probably add a new enum like ShouldUseAnchorAndFocus with values UseAnchorAndFocus and UseStartAndEnd instead of hard-coding if-endif like this.

I could just remove this swizzle completely, instead of #ifdef'ing it, but I assume there was some good reason for doing it in the first place. Any idea what that might be? Do you think I could just go ahead and delete these 4 lines?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.