[Webkit-unassigned] [Bug 96508] [chromium] WebViewImpl::selectionBounds should return start/end on Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96508


Ryosuke Niwa (vacation: 8/26-9/10) <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #163621|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Ryosuke Niwa (vacation: 8/26-9/10) <rniwa at webkit.org>  2012-09-12 08:54:39 PST ---
(From update of attachment 163621)
View in context: https://bugs.webkit.org/attachment.cgi?id=163621&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:2266
> +// "Start" always precedes "end". "Base" is where the user's selection gesture
> +// started, "end" is where it finished. Most platforms want base/extent here.
> +// Android wants start/end even if base/extent are reversed.
> +// FIXME: This shouldn't be OS-specific. http://webkit.org/b/96508

This is very confusing. Why are arguments called start and end, and yet they expect it to be base and extent? Furthermore, they aren't base and extent. They're anchor and focus.
The terminology here is all messed up. Please fix them.

Also, we should probably add a new enum like ShouldUseAnchorAndFocus with values UseAnchorAndFocus and UseStartAndEnd instead of hard-coding if-endif like this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.