[Webkit-unassigned] [Bug 91844] [EFL][WK2] Plugin process implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844





--- Comment #22 from Ryuan Choi <ryuan.choi at samsung.com>  2012-09-12 07:22:50 PST ---
(From update of attachment 163620)
View in context: https://bugs.webkit.org/attachment.cgi?id=163620&action=review

> Source/WebCore/PlatformEfl.cmake:16
> +  "${WEBKIT_DIR}/efl/WebCoreSupport"

I want not to add WebKit dependency.

I will create bug to fix this issue.

> Source/WebKit2/PlatformEfl.cmake:258
> +    SET(PluginProcess_LIBRARIES
> +         ${WebKit2_LIBRARY_NAME}
> +    )

I need to test. but I think that we need javascript core and webcore for shared core build.

> Source/WebKit2/PluginProcess/efl/PluginProcessMainEfl.cpp:76
> +    if (!ecore_x_init(0))
> +        return 1;

I want #ifdef HAVE_ECORE_X

> Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:86
> +void WebPageProxy::createPluginContainer(uint64_t& windowID)

we can remove variable name until we implement.

> Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:91
> +void WebPageProxy::windowedPluginGeometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect, uint64_t windowID)

ditto.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:50
> +#if PLATFORM(GTK) || (PLATFORM(EFL) && USE(CAIRO))

#if USE(CAIRO) && !PLATFORM(WIN_CAIRO)

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:93
> +    return static_cast<Display*>(ecore_x_display_get());

macro is needed.

> Source/cmake/OptionsEfl.cmake:118
> +IF (ENABLE_WEBKIT2)
> +    SET(ENABLE_PLUGIN_PROCESS 1)
> +ENDIF ()

Should we set PLUGIN_PROCESS as a default for WEBKIT2?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.