[Webkit-unassigned] [Bug 94925] [EFL][UT]Refactoring an implementation of testing framework for wk1.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94925





--- Comment #10 from Ryuan Choi <ryuan.choi at samsung.com>  2012-09-12 05:27:31 PST ---
(From update of attachment 163576)
View in context: https://bugs.webkit.org/attachment.cgi?id=163576&action=review

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:69
> +void EWKTestBase::onLoadFinished(void* data, Evas_Object* webView, void* eventInfo)
>  {
> -    return createTest(Config::defaultTestPage, event_callback, event_name, event_data);
> +    UNUSED_PARAM(data);
> +    UNUSED_PARAM(webView);
> +    UNUSED_PARAM(eventInfo);

Could you check whether compiler complains with void EWKTestBase::onLoadFinished(void*, Evas_Object*, void*) ?

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp:44
> +bool EWKTestView::init()

Isn't it better to pass viewtype, width, height instead of keeping them ?

and initialize looks better.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp:76
> +    evas_object_focus_set(m_webView, EINA_TRUE);

true ?

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h:42
> +    void viewTypeSet(EwkViewType testViewType) { m_viewType = testViewType; }

I think that it looks meaningless.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.