[Webkit-unassigned] [Bug 95690] webkit_unit_tests-debug.apk does not include chromium_net.jar.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 12 05:22:41 PDT 2012


--- Comment #16 from Peter Beverloo <peter at chromium.org>  2012-09-12 05:23:06 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > (In reply to comment #12)
> > > (From update of attachment 163344 [details] [details] [details])
> > > Rejecting attachment 163344 [details] [details] [details] from commit-queue.
> > > 
> > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> > > 
> > > ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> > > 
> > > Full output: http://queues.webkit.org/results/13811912
> > 
> > Again?.. Philippe, could you please upload a new patch with the common ChangeLog format? :).
> Sure, I will upload a new patch :) Sorry for the inconvenience. What is the exact workflow I should adopt? Systematically upload a new patch at the end of the review adding the 'Reviewed by...'?

The "Reviewed by (OOPS!)." line is part of the standard ChangeLog message, so it's unclear to me why it isn't there in the first place (unless you removed it manually). There's no need to remove the (OOPS!), the commit queue or webkit-patch will fill it in for you automatically.

An easy workflow which I've adopted is:
1) make changes
2) webkit-patch upload --request-commit

The "webkit-patch upload" command will open a bug for you, set the right title/url, prepare your ChangeLog contents, show you a diff before uploading and then uploading the patch itself, requesting the patch to be committed as well.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list