[Webkit-unassigned] [Bug 96463] [chromium] Evict textures through the texture manager instead of the resource provider

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96463


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #163507|review?                     |review+
               Flag|                            |




--- Comment #3 from James Robinson <jamesr at chromium.org>  2012-09-12 01:52:07 PST ---
(From update of attachment 163507)
View in context: https://bugs.webkit.org/attachment.cgi?id=163507&action=review

R=me, just some really minor things

> Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:56
> +    // Each remaining backing is a leaked opengl texture. There sould be none.

sould->should

> Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:277
> +    evictBackingsToReduceMemory(0, false, resourceProvider);

i think these callsites would all be more readable if you used a 2-state enum for the second parameter instead of a bool. since the callsites are just literals, i have to go look for the definition of evictBackingsToReduceMemory to understand what "false" means

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.