[Webkit-unassigned] [Bug 95672] [EFL][WK2] Add javascript popup api.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95672





--- Comment #29 from Byungwoo Lee <bw80.lee at samsung.com>  2012-09-11 18:52:38 PST ---
(From update of attachment 163486)
View in context: https://bugs.webkit.org/attachment.cgi?id=163486&action=review

>> Source/WebKit2/ChangeLog:22
>> +        * UIProcess/API/efl/tests/test_ewk2_view.cpp:
> 
> Could you mention that you added tests?

Ok~

>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:672
>> +    api->run_javascript_prompt = 0;
> 
> IMO, there are not necessary.

Yes, right. Thanks you.

>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1645
>> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
> 
> priv looks not used.

Yes, smartData->api should be checked. Thanks :)

>> Source/WebKit2/UIProcess/API/efl/ewk_view.h:119
>> +    //   - All string should be guaranteed to be stringshared.
> 
> strings?

Ok~ I'll apply it.

>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:410
>> +    ewkViewClass()->run_javascript_confirm = checkConfirmMessageAndReturnTrue;
> 
> This is not important. but why don't you use title instead of alert?
> 
> It looks better to understand test.

I just used alert for checking return value, and there was some purpose to verify alert callback together.
But as you said, checking title will be more clear and have no dependency with alert callback.
I'll change this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.