[Webkit-unassigned] [Bug 80794] :first-line pseudo selector ignoring words created from :before

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80794





--- Comment #7 from Elliott Sprehn <esprehn at chromium.org>  2012-09-11 16:06:16 PST ---
(From update of attachment 151665)
View in context: https://bugs.webkit.org/attachment.cgi?id=151665&action=review

This seems okay, but the amount of duplication between uncachedFirstLineStyle and firstLineStyleSlowCase seems bad. Can you express one in terms of the other, or add a helper?

> Source/WebCore/rendering/RenderObject.cpp:2514
> +        // For handling content generated from :before/:after pseudo-element.

Not sure these comments are needed. You have the isBeforeOrAfterContent which seems clear.

--- Comment #8 from Elliott Sprehn <esprehn at chromium.org>  2012-09-11 16:06:17 PST ---
(From update of attachment 151665)
View in context: https://bugs.webkit.org/attachment.cgi?id=151665&action=review

This seems okay, but the amount of duplication between uncachedFirstLineStyle and firstLineStyleSlowCase seems bad. Can you express one in terms of the other, or add a helper?

> Source/WebCore/rendering/RenderObject.cpp:2514
> +        // For handling content generated from :before/:after pseudo-element.

Not sure these comments are needed. You have the isBeforeOrAfterContent which seems clear.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.