[Webkit-unassigned] [Bug 90968] [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 11 07:39:09 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=90968
--- Comment #5 from WebKit Review Bot <webkit.review.bot at gmail.com> 2012-09-11 07:39:33 PST ---
Attachment 163359 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/DumpRenderTree/DumpRenderTree.h', u'..." exit_code: 1
Tools/DumpRenderTree/DumpRenderTree.h:75: timeout_ms is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:689: Place brace on its own line for function definitions. [whitespace/braces] [4]
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:689: Missing space before { [whitespace/braces] [5]
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:694: One line control clauses should not use braces. [whitespace/braces] [4]
Tools/DumpRenderTree/DumpRenderTreeCommon.cpp:72: Missing space before { [whitespace/braces] [5]
Tools/DumpRenderTree/DumpRenderTreeCommon.cpp:74: Missing space before { [whitespace/braces] [5]
Tools/DumpRenderTree/DumpRenderTreeCommon.cpp:81: Else clause should never be on same line as else (use 2 lines) [whitespace/newline] [4]
Total errors found: 7 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list