[Webkit-unassigned] [Bug 94858] AX: Regression (r126369) - toggle buttons no longer return accessible titles

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94858


Alejandro Piñeiro <apinheiro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #163331|                            |review?
               Flag|                            |




--- Comment #11 from Alejandro Piñeiro <apinheiro at igalia.com>  2012-09-11 04:26:48 PST ---
Created an attachment (id=163331)
 --> (https://bugs.webkit.org/attachment.cgi?id=163331&action=review)
Fixes the bug

Patch updated after review on comment 8.

> Alternatively, consider a test that just dumps the role and title of each button using debug(), and we could have different expectations for each platform. You can add the test to LayoutTests/accessibility and only add a gtk-specific expectation (e.g. LayoutTests/platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt) in this patch - then I'd be happy to add Mac & Chromium expectations later.

For simplicity, in the end I went to this path. As I said IMHO the test should also check the role, so the approach you proposed (focusable-div.html) was not enough. So this patch add the test to LayoutTests/accessibility, and the gtk-specific expectation. Mac & Chromium expectations are missing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.