[Webkit-unassigned] [Bug 95346] Get rid of device/host clock synchronization.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95346





--- Comment #36 from Philippe Liard <pliard at chromium.org>  2012-09-11 02:47:17 PST ---
(From update of attachment 163137)
View in context: https://bugs.webkit.org/attachment.cgi?id=163137&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:410
>> +                                 'Please pass --%s.', configuration, most_recent_binary, most_recent_binary.lower())
> 
> As an aside, this warning has always kinda annoyed me since there's no way to make it go away; if you're trying to run both Release and Debug, one will always be newer than the other (unless you hack the mtime, of course). I wonder how much this warning actually helps people.

This kind of code is duplicated across multiple places in the Chromium Android Python codebase. We clearly miss a way to figure out the build type in a single line regardless of the language (Python or Shell). I think we have a bug tracking that. If I remember correctly we plan to make GYP output the build type to a file in out/. This code can be updated once we landed that change.

>> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:385
>> +                                 stdout=subprocess.PIPE).stdout)
> 
> You can use self._port.host.executive.popen() here and below -  that's slightly preferred to calling subprocess.Popen() directly.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.