[Webkit-unassigned] [Bug 96114] [chromium] Make prioritized texture manager not touch backings array on the main thread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96114





--- Comment #26 from Christopher Cameron <ccameron at chromium.org>  2012-09-10 21:17:09 PST ---
(From update of attachment 163246)
View in context: https://bugs.webkit.org/attachment.cgi?id=163246&action=review

>> Source/WebKit/chromium/tests/CCPrioritizedTextureTest.cpp:521
>> +    DebugScopedSetImplThreadAndMainThreadBlocked implThreadAndMainThreadBlocked;
> 
> I'm confused as to why this is passing. Shouldn't the backings be unsorted due to requestLate, and result in an ASSERT below because they aren't sorted?
> 
> Hmm, perhaps the backing list is out of date but still sorted in the old valid order (since certain values are copied to backings now). In any case I think we need to tweak this so it fails, or test this another way.

Ah, so this wasn't actually testing anything!  The backings are out-of-date (and therefore still sorted)!

I updated the test to sort the backings explicitly, and the verify that the textures' backings have the right "isAbovePriorityThreshold".  In order to do this, I made CCPrioritizedTextureTest be a friend of the CCPTM and CCPT classes, so it can reach in and inspect this state.  I also made some functions (assertInvariants and updateBackingsPriorities private again).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.