[Webkit-unassigned] [Bug 95173] [EFL][WK2] Add necessary include directories in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95173





--- Comment #18 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-09-10 20:57:33 PST ---
(From update of attachment 163031)
View in context: https://bugs.webkit.org/attachment.cgi?id=163031&action=review

>>> Source/WebKit2/CMakeLists.txt:114
>>> +IF (WTF_USE_3D_GRAPHICS)
>> 
>> I think WebKit2/PlatformEfl.cmake is proper place because this build break occurs at EFL port only now.
> 
> Hmm, IMO, it may be not a EFL port only problem even it just triggers problem on EFL platform now. The root cause is that when TEXTURE_MAPPER is enabled, some source files in WebKit2 include TextureMapperGL.h --> GraphicsContext3D -->trigger build problem. And as I know, TEXTURE_MAPPER is not EFL only， right? And those files which include TextureMapperGL.h are also not all for EFL platform only, for example the ShareableSurface.cpp.
> 
> Any further comments?

Of course, it seems to me all ports (EFL, blackberry and wince) will need to include "GLSLANG" directory if they need to use WEBGL(3D_GRAPHICS)
But, blackberry and wince ports don't start to support WK2 yet. So, I would remain to add this to EFL private file until they need to use the "GLSLANG". Because, there will may something stuff further.

In WK1 case, blackberry port also include this directory in PlatformBlackBerry.cmake.
http://trac.webkit.org/browser/trunk/Source/WebKit/PlatformBlackBerry.cmake#L120

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.