[Webkit-unassigned] [Bug 96201] [EFL][WK2] WKEinaSharedString needs a function to adopt eina stringshare.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96201





--- Comment #22 from Byungwoo Lee <bw80.lee at samsung.com>  2012-09-10 17:55:47 PST ---
(In reply to comment #21)
> (From update of attachment 163110 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163110&action=review
> 
> > Source/WebKit2/UIProcess/API/cpp/efl/WKEinaSharedString.cpp:114
> > +{
> > +    WKEinaSharedString sharedString;
> > +    sharedString.m_string = static_cast<const char*>(string);
> > +    return sharedString;
> > +}
> 
> So that will copy and deallocate the local one. I suppose the copy constructor is effective :-)
Ok~ then I'll add some private constructor that just adopt eina_stringshare, and use it.
But I have a question.
On the previous patch, I defined the private constructor like below.
+    // Aopting constructor
+    WKEinaSharedString(Eina_Stringshare* string, bool) : m_string(string) { }

I referenced the adopting constructor of PassRefPtr.
Additional bool parameter seems to have some purpose for preventing some mistakes.
Should I follow this way for WKEinaSharedString?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.