[Webkit-unassigned] [Bug 96114] [chromium] Make prioritized texture manager not touch backings array on the main thread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96114





--- Comment #21 from Eric Penner <epenner at chromium.org>  2012-09-10 13:26:54 PST ---
(In reply to comment #19)
> The backings are guaranteed to be sorted at all times, however, their sorting may be with respect to the last snapshot, but it may be that the main thread has made some changes to the priorities that have not yet been committed.

The reason I still prefer the lazy scheme is that I don't see any reason why we couldn't just sort the backings again in this case. If the main thread changed priorities then it must have also called prioritizeTextures(), and it would never change any priorities further after that, so we it seems like we should definitely sort the backings.

If we did go back to the lazy scheme, would it be even easier if the 'needsBackingSort' flag was set during PrioritizeTextures and unset during PrioritizeBackings? Then we could add ASSERT(!needsBackingSort) to make sure the main thread doesn't change anything between the two sorting steps, and also insure that either a.) sortBackings is called externally always, or b.) sortBackingsIfNeeded is always called first internally.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.