[Webkit-unassigned] [Bug 78493] [CSSRegions][CSSOM] Implement Element.getRegionFlowRanges

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 12:06:24 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=78493


Raul Hudea <rhudea at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162511|0                           |1
        is obsolete|                            |
 Attachment #163176|                            |review?, commit-queue?
               Flag|                            |




--- Comment #10 from Raul Hudea <rhudea at adobe.com>  2012-09-10 12:06:45 PST ---
Created an attachment (id=163176)
 --> (https://bugs.webkit.org/attachment.cgi?id=163176&action=review)
Remove the copy-pasted toInt()

- As discussed on IRC, the isWritingModeRoot is using the parent style writing mode, while here is needed the container's one
- For now, I would like to leave the writing mode code as is. If there were a function like flipForWritingModeForBlock(RenderBlock*, LayoutRect&) the code would be just:

   container->flipForWritingModeForBlock(currentBlock, rect);
   currentBlock->flipForWritingMode(rect);

  In the worst case, you need to do two flips.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list