[Webkit-unassigned] [Bug 95977] webkit build for 64-bit Mac chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95977





--- Comment #5 from Catalin badea <badea at adobe.com>  2012-09-10 10:07:47 PST ---
Thank you for the review.

(In reply to comment #3)
> (From update of attachment 162501 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162501&action=review
> 
> > Source/WebKit/chromium/public/mac/WebSubstringUtil.h:34
> > +#include "../platform/WebCommon.h"
> 
> This seems like an odd way to include a header?  Are you sure this is proper form?  Maybe <platform/WebCommon.h> ?

I've followed the headers in WebKit/chromium/public/mac/ as examples.

> > Source/WebKit/chromium/src/mac/WebSubstringUtil.mm:35
> > +#import <Cocoa/Cocoa.h>
> 
> Why the re-org?

Cocoa/Cocoa.h needs to be included first in order for the SGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES macro to be defined
before the contents of FloatSize.h & similar headers are being preprocessed ensuring that no extra constructors will be declared.
This also complies with header include ordering.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.