[Webkit-unassigned] [Bug 96171] [Qt] Implement WebNotification in WebKit2 port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96171


Olivier Crête <olivier.crete at collabora.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162931|0                           |1
        is obsolete|                            |




--- Comment #5 from Olivier Crête <olivier.crete at collabora.com>  2012-09-10 08:45:14 PST ---
Created an attachment (id=163140)
 --> (https://bugs.webkit.org/attachment.cgi?id=163140&action=review)
better patch

Thanks for the quick review, here is a patch that fixes the style/etc issues. As for the issue of using QSystemTrayIcon, it's use was suggested by Thiago. I'm really unconvinced that forcing every app to re-implement notifications is a good idea as it's really a platform thing. I have  a couple possible proposals on how to implement it:

1. Move QSystemTrayIcon out of QtWidgets, it's not a QWidget and only the Unix implementation uses a QWidget I believe. Maybe that could be replaced with using the libnotify dbus API? That would only depend on QtCore. My goal was to implement the platform specific bits in the QPA instead of spreading them into QtWebKit.
2. We could use weak linking for the QSystemTrayIcon to use it if it's linked against QtWidget and do nothing if it's not there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.