[Webkit-unassigned] [Bug 95346] Get rid of device/host clock synchronization.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 10 06:27:31 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=95346
--- Comment #26 from Peter Beverloo <peter at chromium.org> 2012-09-10 06:27:50 PST ---
(In reply to comment #25)
> (From update of attachment 163098 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163098&action=review
>
> >> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:128
> >> + '<(chromium_src_dir)/tools/android/md5sum/md5sum.gyp:md5sum',
> >
> > This needs to be specific to Android, i.e. in a conditional block.
>
> Indeed.
>
> >> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:328
> >> + if not worker_number in self._data_already_pushed_for_worker:
> >
> > The _data_already_pushed_for_worker variable is a member of this class, and since this is the __init__ method, won't it always be empty at this point?
>
> I'm still quite new to Python. I wanted to make it a static member. Isn't that the case? I read somewhere that member variables declared in the non-method scope are static.
Ah, I see. You probably should be using "ChromiumAndroidDriver._data_already_pushed_for_worker" to access the variable, then.
The rest LGTM.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list