[Webkit-unassigned] [Bug 95346] Get rid of device/host clock synchronization.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95346





--- Comment #23 from Peter Beverloo <peter at chromium.org>  2012-09-10 05:44:43 PST ---
(From update of attachment 163098)
View in context: https://bugs.webkit.org/attachment.cgi?id=163098&action=review

A few minor nits. Looks fine overall, except for the build failure (I commented on that later on).

> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:128
> +                '<(chromium_src_dir)/tools/android/md5sum/md5sum.gyp:md5sum',

This needs to be specific to Android, i.e. in a conditional block.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:328
> +        if not worker_number in self._data_already_pushed_for_worker:

The _data_already_pushed_for_worker variable is a member of this class, and since this is the __init__ method, won't it always be empty at this point?

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:385
> +                                 stdout=subprocess.PIPE).stdout)

nit: It's fine to leave it like this (since it may become unreadable otherwise), but WebKit has no limit on line lengths.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:677
> +                if last_char in ['#', '$']:

nit: could use a tuple here (which is preferred for lists in gyp).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.