[Webkit-unassigned] [Bug 94384] screenToWindow and windowToScreen are not implemented in Qt5 WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 8 10:51:24 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=94384





--- Comment #13 from Andras Becsi <abecsi at webkit.org>  2012-09-08 10:51:39 PST ---
(From update of attachment 162932)
View in context: https://bugs.webkit.org/attachment.cgi?id=162932&action=review

This looks better :)

> Source/WebKit2/ChangeLog:8
> +        QtWebKit2: Implement windowToScreen and screenToWindow in QtPageClient
> +
> +        Enables WebCore to find where on the Screen a point is.
> +
> +        screenToWindow and windowToScreen are not implemented in Qt5 WebKit2
> +        https://bugs.webkit.org/show_bug.cgi?id=94384

The ChangeLog should start with the bug title then the bug URL and then the description.
To match the usual naming convention the bug title should probably be: [Qt][WK2] QtPageClient's screenToWindow and windowToScreen are not implemented

> Source/WebKit2/UIProcess/qt/QtPageClient.cpp:194
> +    if (!m_webView)
> +        return point;

Since the QtPageClient is created and initialized by QQuickWebView the m_webView pointer here should be valid for the entire lifetime of QtPageClient, thus this check can be an ASSERT instead.

> Source/WebKit2/UIProcess/qt/QtPageClient.cpp:204
> +    if (!m_webView)
> +        return point;

This can be omitted, see above.

> Source/WebKit2/UIProcess/qt/QtPageClient.cpp:206
> +    return m_webView->mapFromScene(windowPoint);

As the EWS points out the Qt-WK2 build fails because toPoint() is missing here.

> Source/WebKit2/UIProcess/qt/QtPageClient.cpp:212
> +    if (!m_webView)
> +        return rect;

ASSERT instead, see above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list