[Webkit-unassigned] [Bug 96114] [chromium] Make prioritized texture manager not touch backings array on the main thread

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 12:20:06 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96114





--- Comment #3 from Eric Penner <epenner at chromium.org>  2012-09-07 12:20:21 PST ---
(From update of attachment 162787)
View in context: https://bugs.webkit.org/attachment.cgi?id=162787&action=review

I really like this. It also helps break things up into more clear stages IMO, by not needing to keep backings ready for eviction at all times.

> Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:176
>      texture->setAbovePriorityCutoff(true);

I think there might be a subtle issue with removing this. If you requestLate() then this texture is chosen to be allocated in front of all other texture that have the same priority, even though the group of equal-priority textures didn't make the cut (this only really happens when we are totally OOM).

I think this could be handled by making the backing sort use this flag to sort backings correctly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list