[Webkit-unassigned] [Bug 95614] Add support for blendmode to platform code for mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95614





--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-09-07 08:13:12 PST ---
(In reply to comment #7)
> > > Source/WebCore/rendering/RenderLayerBacking.cpp:253
> > > +void RenderLayerBacking::updateLayerBlendMode(const RenderStyle* style)
> > 
> > 'layer' here is redundant.
> 
> It's the same as updateLayerFilters, updateLayerOpacity & updateLayerTransform.
> Should those functions change as well?

Yes, but you don't have to do that in this patch.

> > I think it's very confusing to use the term "compositing" in code which is all about accelerated compositing. Maybe use "blending" instead?
> 
> To clarify, this function will also be used to set up the compositing modes and group isolation.

I still think using the term "compositing" unqualified in the context of GraphicsLayer is very confusing. I think a less confusing but not quite accurate name would be better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.