[Webkit-unassigned] [Bug 95923] [EFL] Implement GCActivityCallback with platform timer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95923


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162393|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-09-06 17:37:15 PST ---
(From update of attachment 162393)
View in context: https://bugs.webkit.org/attachment.cgi?id=162393&action=review

> Source/JavaScriptCore/PlatformEfl.cmake:2
> +    runtime/GCActivityCallback.cpp

In this file case, I think we're able to remove this file in CMakeLists.txt. Then, we can add a port specific file to PlatformXXX.cmake by port itself. So, I'm going to file a bug for this.

> Source/JavaScriptCore/PlatformEfl.cmake:10
> +    runtime/GCActivityCallbackEfl.cpp

Wrong alphabetical order.

> Source/JavaScriptCore/PlatformEfl.cmake:19
> +    ${ECORE_X_INCLUDE_DIRS}

ditto.

> Source/JavaScriptCore/heap/HeapTimer.cpp:147
> +        ecore_timer_del(m_timer);

A new line ?

> Source/JavaScriptCore/heap/HeapTimer.h:77
> +    Ecore_Timer* m_timer;

Can't you use OwnPtr here ? If you can use OwnPtr for this, you'd be able to remove most of the checks for m_timer as well as calls to ecore_timer_del() in this patch.

See also, RunLoopEfl.h / cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.