[Webkit-unassigned] [Bug 96018] [chromium] Do not delete CCPrioritizedTexture::Backing structures on the main thread

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 14:30:58 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96018





--- Comment #6 from Christopher Cameron <ccameron at chromium.org>  2012-09-06 14:31:12 PST ---
Thanks!  ChangeLog fixed.

(In reply to comment #5)
> (From update of attachment 162571 [details])
> Seems okay to me. I'd be fine creating a one-off list for the impl thread to use and keep this totally single threaded, but by splitting ownership of this class between threads we won't even need such a list?

Yes, we'll be able to avoid the extra list.

> It looks like the only function that executes on the main thread and touches m_backings is PrioritizeTextures(), so it shouldn't be too hard to never touch m_backings on the main thread with a bit more work. Everything else occurs during the commit.

Yes, looks like it won't need to do that much.

> I'm fine with this as long as at the end of the day this class can still be used on one thread as well (by just removing the thread asserts if that ever happens).

Yes, if/when we need it to be single-threaded (e.g, impl side painting), we'll need to kill off the asserts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list