[Webkit-unassigned] [Bug 96001] [BlackBerry] Implement a color picker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96001





--- Comment #6 from Crystal Zhang <haizhang at rim.com>  2012-09-06 12:39:20 PST ---
(In reply to comment #2)
> (From update of attachment 162544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162544&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:47
> > +ColorPickerClient::~ColorPickerClient()
> > +{
> > +}
> 
> lets omit this?
> 
> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:79
> > +IntSize ColorPickerClient::contentSize()
> 
> const
> 
Can't add const here as the function comes from parent class.

> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:81
> > +    // Fixme: will generate content size dynamically
> 
> FIXME*
> 
> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:85
> > +String ColorPickerClient::htmlSource()
> 
> const

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.