[Webkit-unassigned] [Bug 95625] [CSS Exclusions] add support for a subset of the basic shapes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95625





--- Comment #14 from Hans Muller <giles_joplin at yahoo.com>  2012-09-06 11:33:44 PST ---
(In reply to comment #5)
> (From update of attachment 161830 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161830&action=review

> > Source/WebCore/ChangeLog:8
> > +        Initial commit of a subset of the Xhapes classes.
> 
> Typo, should be XShapes.
> 
> > Source/WebCore/ChangeLog:10
> > +        This set of classes enables the exclusions layout code to determine how to break up a line into segements
> 
> Typo, segements should be segments.

I have fixed these typos.

> > Source/WebCore/platform/graphics/XSRectangle.h:54
> > +    virtual FloatRect shapeBoundingBox() const { return FloatRect(m_x, m_y, m_width, m_height); }
> > +    virtual void getOutsideIntervals(float y1, float y2, Vector<XSInterval>&) const;
> > +    virtual void getInsideIntervals(float y1, float y2, Vector<XSInterval>&) const;
> 
> You're missing OVERRIDEs on these three functions

Added the OVERRIDES.

> 
> > Source/WebCore/platform/graphics/XSRectangle.h:62
> > +    float m_rx;
> > +    float m_ry;
> 
> I would add a comment here explaining what these are. A person who isn't familiar with this code will see x,y,width,height and understand those, but may be left scratching their head wondering what m_rx and m_ry are here.

Added comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.