[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #14 from Gustavo Noronha (kov) <gns at gnome.org>  2012-09-06 10:16:29 PST ---
(In reply to comment #12)
> > I think we should always default to 127.0.0.1 if no explicit IP is given, opening up the server to a public IP would be quite bad, so I'd remove this function. If you need for your particular use-case you can add this kind of logic to the browser afterwards, or to a wrapper that starts the browser with the environment variable filled.
> 
> That was one of your comments that it would be good to get IP address somehow :). Don't really need it, so will remove it anyway.

I couldn't find where I said this, maybe I said something misleading, but I didn't mean that.

(In reply to comment #13)
> > Will undo my change here, hopefully there will be more generic approach in the future.
> 
> I found one place which should be good for the server initialization: void WebContext::platformInitializeWebProcess(WebProcessCreationParameters&) in WebContextGtk.cpp.
> However with this approach the server will start up regardless if developer extras is enabled or not. (The same for QT port). That doesn't seem to be correct. That's why
> in one of my previous patches I started the server in WebPageProxy::initializeWebPage() after checking developer extras. What do you think?

I think we should just do what Qt does, for now; if the developer has used the environment variable, then it's safe to assume they want it, even without checking the developer extras setting. When we add API to open up the server in the future we can think about how it will interact with developer extras.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.