[Webkit-unassigned] [Bug 93998] [chromium] More Android changes to WebFrameImpl::selectRange

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93998





--- Comment #9 from Iain Merrick <husky at chromium.org>  2012-09-06 06:49:25 PST ---
(From update of attachment 160944)
View in context: https://bugs.webkit.org/attachment.cgi?id=160944&action=review

>> Source/WebKit/chromium/src/WebFrameImpl.cpp:-1482
>> -    if (frame()->selection()->shouldChangeSelection(newSelection))
> 
> Looks like we lost this call.  Is this no longer needed?

Oops, good catch. setNonDirectionalSelectionIfNeeded() calls that internally, but setSelection() doesn't. I'll put it back in.

>> Source/WebKit/chromium/src/WebFrameImpl.cpp:1486
>> +        return false;
> 
> Should this ASSERT?  Is it an error to call this function without a current selection?

I thought it best to return a bool result code, for consistency with the existing selectWordAroundCaret.

This is going to be called from way over in Java-land, so it seems good to be defensive about the exact editing state, rather than just asserting that it's correct. For example, a Javascript hook might clear the selection concurrently with the Java UI code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.