[Webkit-unassigned] [Bug 95924] Deploy StringBuilder in more places in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95924





--- Comment #16 from Ryuan Choi <ryuan.choi at samsung.com>  2012-09-06 06:03:29 PST ---
(From update of attachment 162421)
View in context: https://bugs.webkit.org/attachment.cgi?id=162421&action=review

It looks almost fine to me.

Below are some nit.

> Source/WebKit2/ChangeLog:9
> + 

one space.

> Source/WebKit2/Shared/WebMemorySampler.cpp:49
> +    : m_separator(ASCIILiteral("\t"))  

remove spaces at end of lien.

> Source/WebKit2/Shared/WebMemorySampler.cpp:151
>              header.append(stats.keys[i].utf8().data());

stats.keys[i] looks enough.

> Source/WebKit2/Shared/WebMemorySampler.cpp:176
> +    StringBuilder statString; 

space.

> Source/WebKit2/Shared/WebMemorySampler.cpp:187
> +    statString.append('\n');
> +    

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.