[Webkit-unassigned] [Bug 95937] [Gtk] GObject DOM generator should consider conditionals for EventTarget interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95937





--- Comment #3 from José Dapena Paz <jdapena at igalia.com>  2012-09-06 01:22:30 PST ---
(In reply to comment #2)
> Attachment 162437 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> Source/WebCore/bindings/scripts/test/ObjC/DOMTestConditionalEventTargetInternal.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
> Source/WebCore/bindings/scripts/test/JS/JSTestConditionalEventTarget.h:62:  More than one command on the same line in if  [whitespace/parens] [4]
> Source/WebCore/bindings/scripts/test/CPP/WebDOMTestConditionalEventTarget.h:44:  The parameter name "listener" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebCore/bindings/scripts/test/CPP/WebDOMTestConditionalEventTarget.h:45:  The parameter name "listener" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebCore/bindings/scripts/test/CPP/WebDOMTestConditionalEventTarget.cpp:34:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
> Total errors found: 5 in 15 files

Unfortunately all these reports are caused by bugs in bindings generators. The generated code does not match our style guidelines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.