[Webkit-unassigned] [Bug 95937] [Gtk] GObject DOM generator should consider conditionals for EventTarget interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 00:45:46 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=95937





--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-09-06 00:45:59 PST ---
Attachment 162437 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/scripts/test/ObjC/DOMTestConditionalEventTargetInternal.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/bindings/scripts/test/JS/JSTestConditionalEventTarget.h:62:  More than one command on the same line in if  [whitespace/parens] [4]
Source/WebCore/bindings/scripts/test/CPP/WebDOMTestConditionalEventTarget.h:44:  The parameter name "listener" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/CPP/WebDOMTestConditionalEventTarget.h:45:  The parameter name "listener" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/CPP/WebDOMTestConditionalEventTarget.cpp:34:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
Total errors found: 5 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list