[Webkit-unassigned] [Bug 95924] Deploy StringBuilder in more places in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95924





--- Comment #15 from Jinwoo Song <jinwoo7.song at samsung.com>  2012-09-05 22:58:53 PST ---
(In reply to comment #10)
> (From update of attachment 162403 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162403&action=review
> 
> > Source/WebKit2/Shared/WebMemorySampler.cpp:141
> > +    processDetails.appendLiteral("\n");
> 
> append('\n') looks better.
done.

> 
> > Source/WebKit2/Shared/WebMemorySampler.cpp:142
> > +    writeToFile(m_sampleLogFile, processDetails.toString().utf8().data(), processDetails.toString().utf8().length());
> 
> I am not sure, but isn't it better to keep String reference instead of using toString twice ?
done. 
> 
> > Source/WebKit2/Shared/WebMemorySampler.cpp:153
> > +    header.appendLiteral("\n");
> > +    writeToFile(m_sampleLogFile, header.toString().utf8().data(), header.toString().utf8().length());
> 
> Ditto.
done.

> 
> > Source/WebKit2/Shared/WebMemorySampler.cpp:184
> > +    statString.appendLiteral("\n");
> > +    writeToFile(m_sampleLogFile, statString.toString().utf8().data(), statString.toString().utf8().length());
> 
> Ditto.
done.

> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:127
> > +    etringBuilder result;
> 
> Typo
done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.