[Webkit-unassigned] [Bug 95758] [chromium] Adjust texture priorities in preparation of impl-thread eviction of only some textures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95758





--- Comment #21 from Christopher Cameron <ccameron at chromium.org>  2012-09-05 16:18:19 PST ---
(In reply to comment #19)
> View in context: https://bugs.webkit.org/attachment.cgi?id=162316&action=review
> 
> > Source/WebCore/platform/graphics/chromium/cc/CCPriorityCalculator.cpp:34
> > +static const int kUiDrawsToRootSurface            =      -1;
> > +static const int kVisibleDrawsToRootSurface       =       0;
> 
> These named constants are way better.
> 
> style nit: In general, WebKit style is not to use kFoo for named static variables.  Usually this would just be like "visibleDrawsToRootSurface" and not "kVisibleDrawsToRootSurface".

Ah -- fixed (changed them to visibleDrawsToRootSurfacePriority, etc).

> style nit: Please don't use whitespace to vertically align anything.

Fixed.

> nit: maybe kNotVisibleBase + 512?

Good point -- fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.