[Webkit-unassigned] [Bug 95057] [chromium] Allow impl-thread deletion of only some resources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95057





--- Comment #36 from Christopher Cameron <ccameron at chromium.org>  2012-09-05 14:55:42 PST ---
(In reply to comment #34)
> (In reply to comment #33)
> > So there does exist a bug here -- a reduceMemory() call can destroy a backing that has been handed to the main thread, but the main thread hasn't deleted yet.  I don't see a way around that without basically going back to the scheme of having a list of evicted textures in the PTM which is protected by a mutex (so, going back to the old scheme).
> 
> Can this actually happen though? reduceMemory() can only occur during a commit when the main thread is blocked, and it appears as though there can not be any other list of evicted backings in flight from when the task is posted through to when the commit is finished. So it seem to me we just need to process that list during the commit and we should be fine.
>
> > The mutex-protected list of evicted textures would still be needed, though.
> 
> I might be wrong, but could mutex be avoided like this?
> <snip>

I think that you are right, but it's not very clear.  I feel very confident about correctness and performance of the mutex scheme, and I'd prefer to check that in first.

I've cleaned up the CL to have a smaller surface area (removing the separated shared state).  Is it okay in its current form?

[Btw, I'm having trouble with the patch not applying to TOT... I may upload a new version in a bit -- it won't differ substantially from the most current patch]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.