[Webkit-unassigned] [Bug 95322] [chromium] Fix double call to scrollBegin() when handling scroll gesture

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 10:49:28 PDT 2012


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #162253|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #11 from James Robinson <jamesr at chromium.org>  2012-09-05 10:49:41 PST ---
(From update of attachment 162253)
View in context: https://bugs.webkit.org/attachment.cgi?id=162253&action=review

> Source/WebKit/chromium/ChangeLog:23
> +        doesn't seem to represent normal usage -- composited flings don't turn into
> +        main thread flings halfway through.

Sorry, yes they do for wheel flings.  This test and the behavior it tests are important.

> Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp:333
> +    m_inputHandlerClient->scrollBy(IntPoint(m_wheelFlingParameters.point.x, m_wheelFlingParameters.point.y),

This doesn't look right.  Keep in mind we have 2 kinds of flings - "gesture" flings and "wheel pad" flings.  The former is what Chrome on android has.  The latter - which is what this code implements - works like OS X fling by generating a sequence of synthetic wheel events.

It looks like you've just deleted the code for the second kind of fling completely.  That's definitely not the right fix!

I think what you really want to do is for wheel fling type scrolls send a matching scrollEnd() to the scrollBegin() when the fling starts.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list