[Webkit-unassigned] [Bug 95735] Removed V8IsolatedContext

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 10:23:50 PDT 2012


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #162221|review?, commit-queue-      |review+, commit-queue+
               Flag|                            |

--- Comment #9 from Adam Barth <abarth at webkit.org>  2012-09-05 10:24:03 PST ---
(From update of attachment 162221)
View in context: https://bugs.webkit.org/attachment.cgi?id=162221&action=review

This looks great.  Is that test failure really caused by this patch?  Let's try running it through the commit-queue.

> Source/WebCore/bindings/v8/ScriptController.cpp:336
> +            ASSERT(iter->second->world()->worldId() == worldId);
> +            ASSERT(iter->second->world()->extensionGroup() == extensionGroup);
> +           return iter->second;

Bad indent.

> Source/WebCore/bindings/v8/SharedPersistent.h:47
> +            return adoptRef(new SharedPersistent<T>(v8::Persistent<v8::Context>::New(value)));

I would have just make this class hold a ScopedPersistent, but let's not worry about that since we're going to remove it shortly.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list