[Webkit-unassigned] [Bug 93443] Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 07:22:15 PDT 2012


--- Comment #22 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-09-05 07:22:28 PST ---
(From update of attachment 162236)
View in context: https://bugs.webkit.org/attachment.cgi?id=162236&action=review

> Source/WebCore/inspector/front-end/CSSStyleModel.js:1403
> +    for (var i = 0; i < payload.length; ++i) {

This use without any preliminary checks is going to fail, given that you declare payload as nullable and optional (any reason for it to be both?) From the code, it seems that payload can be neither null, nor undefined (unless null comes in from the backend).

> Source/WebCore/inspector/front-end/CSSStyleModel.js:1434
> +        if (namedFlow === undefined)

According to the WebKit coding guidelines, this should be "if (!namedFlow)"

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list