[Webkit-unassigned] [Bug 95649] Web Inspector: CodeGeneratorInspector.py: support asynchronous command implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95649





--- Comment #13 from Yury Semikhatsky <yurys at chromium.org>  2012-09-05 04:54:49 PST ---
(In reply to comment #10)
> > Please fix the failing tests and attach an example diff of the generated code.
> > > Source/WebCore/inspector/CodeGeneratorInspector.py:1953
> > > +    void sendResponse(long callId, PassRefPtr<InspectorObject> result, ErrorString invocationError);
> > |result| type should be InspectorObject* instead of PassRefPtr<InspectorObject>.
> The farther API requires RefPtr style, thus making it RefPtr here.
> 
I would argue that they should be changed as well:)

> > > Source/WebCore/inspector/CodeGeneratorInspector.py:2208
> > > +    return !m_alreadySent && m_backendImpl->isActive();
> > In theory we may end up sending response for a long-running command to a different frontend. Consider the following sequence: FE1 attaches and sends request1, then FE1 is detached and FE2 is attached, now reponse for the request1 is sent.
> 
You are right. I missed that we create new instance of the dispatcher when FE connects.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.