[Webkit-unassigned] [Bug 88291] [EFL] Implement to support layout test of notifications.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 23:25:50 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88291


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145760|review?                     |review-
               Flag|                            |




--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-09-04 23:26:02 PST ---
(From update of attachment 145760)
View in context: https://bugs.webkit.org/attachment.cgi?id=145760&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:68
> +            printf("DESKTOP NOTIFICATION: contents at %s\n", notification->url().string().utf8().data());

As above comment, we have print console message in DRT side. Please move this to DRT side.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:52
> +    static bool dumpNotification;

We don't need to use this flag if you move console message to DRT side.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list