[Webkit-unassigned] [Bug 95057] [chromium] Allow impl-thread deletion of only some resources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95057





--- Comment #25 from Christopher Cameron <ccameron at chromium.org>  2012-09-04 18:14:09 PST ---
(From update of attachment 161809)
View in context: https://bugs.webkit.org/attachment.cgi?id=161809&action=review

Thanks!

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:62
>      virtual void postAnimationEventsToMainThreadOnImplThread(PassOwnPtr<CCAnimationEventsVector>, double wallClockTime) = 0;

Yes -- we could communicate the list of destroyed backings to the main thread at commit time -- we would call getAndClearEvictedBackings on the impl thread and communicate them via scheduledActionBeginFrame.  I had originally started with this scheme, and then abandoned it because the implementation was getting complicated -- copying the set of backings to and from the main thread was involved.

In the intervening iteration, it looks like it's not terribly complicated.  That said, there was some discussion of wanting the PTM to have a mutex for moving towards impl-side painting.  I'm very open to changing back to the scheme of passing the set of evicted textures to the main thread, but I'm getting a bit worried about vascilating too much before checking anything in.

> Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:80
>      void reduceMemory(CCResourceProvider*);

I wanted to name this as reduceMemoryOnImplThread because that's what the function will do in a subsequent change (I renamed a few things from "clear all" to "reduce").

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.