[Webkit-unassigned] [Bug 95758] [chromium] Adjust texture priorities in preparation of impl-thread eviction of only some textures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 17:40:11 PDT 2012


--- Comment #6 from Eric Penner <epenner at chromium.org>  2012-09-04 17:40:24 PST ---
(From update of attachment 162121)
View in context: https://bugs.webkit.org/attachment.cgi?id=162121&action=review

Regarding passing the priority calculator object around, don't let me stop you from removing it. I think I was just pushing back against removing it myself during the original patch (in order to get it landed) so feel free to clean it up as you like.  Previously it looked like we would use layer ordering which would require passing an object around, but that looks quite unlikely now.

> Source/WebCore/platform/graphics/chromium/cc/CCPriorityCalculator.cpp:32

Very much like these constants in one place :)

> Source/WebCore/platform/graphics/chromium/cc/CCPriorityCalculator.cpp:36
> +static const int kUiDoesNotDrawToRootSurface      =       2;

I think it's okay to make all UI textures at the same priority, above everything else.

> Source/WebCore/platform/graphics/chromium/cc/CCPriorityCalculator.cpp:41
> +// less than a half-viewport away are considered "near".

Half a viewport seems low to me. Would 2 viewports be okay?

> Source/WebCore/platform/graphics/chromium/cc/CCPriorityCalculator.cpp:54
> +static const int kFarFromVisibleBase              =  300050;

Could we possibly just squash these into the above lingering group?  There could be many lingering textures (enough to use all remaining memory) and I would rather not have them take away memory from closer textures. Could we just start calling all textures lingering after a certain distance limit is reached?

> Source/WebCore/platform/graphics/chromium/cc/CCPriorityCalculator.cpp:100
> +    {

Could we call the manhattanDistance function here and then normalize to viewport units? I feel it's more clear what the code is doing that way.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list